You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I excluded --no-colors because we don't didn't document it yet and I don't want to rush into things.
Sections are now separated by tool. We might want to review the sections in the future (together with the CLI and the global arguments, but not in this PR).
One additional thing that needs to be done for the release is temporarily downgrading the severity level of all error diagnostics emitted by the linter to warnings so they don't cause CI mode to fail, at least while the linter is unstable
One additional thing that needs to be done for the release is temporarily downgrading the severity level of all error diagnostics emitted by the linter to warnings so they don't cause CI mode to fail, at least while the linter is unstable
Would you be able to put up a PR for this today, ideally in the morning so that the release is ready in the afternoon? If not, then I can try to do it but would first need to figure out how to do that.
Would you be able to put up a PR for this today, ideally in the morning so that the release is ready in the afternoon? If not, then I can try to do it but would first need to figure out how to do that.
It's a very simple change for only two rules in the analyzer so I could just add it to the release/0.6.0 branch for this PR and it shouldn't cause any conflict
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2506
I excluded
--no-colorsbecause we don't didn't document it yet and I don't want to rush into things.Sections are now separated by tool. We might want to review the sections in the future (together with the CLI and the global arguments, but not in this PR).
Test Plan
Check the deployed website and it's correct